Python wheel building improvements#10466
Python wheel building improvements#10466dogganon wants to merge 2 commits intoNatLabRockies:developfrom
Conversation
|
@dogganon @Myoldmopar it has been 28 days since this pull request was last updated. |
3 similar comments
|
@dogganon @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@dogganon @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@dogganon @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@dogganon @Myoldmopar it has been 29 days since this pull request was last updated. |
|
@dogganon @Myoldmopar it has been 28 days since this pull request was last updated. |
2 similar comments
|
@dogganon @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@dogganon @Myoldmopar it has been 28 days since this pull request was last updated. |
|
@dogganon it has been 20 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
2 similar comments
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 8 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
9 similar comments
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 8 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
3 similar comments
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 9 days since this pull request was last updated. |
1 similar comment
|
@dogganon it has been 9 days since this pull request was last updated. |
|
@dogganon it has been 8 days since this pull request was last updated. |
|
@dogganon it has been 14 days since this pull request was last updated. |
|
@dogganon it has been 12 days since this pull request was last updated. |
|
@dogganon it has been 8 days since this pull request was last updated. |
1 similar comment
|
@dogganon it has been 8 days since this pull request was last updated. |
|
@dogganon it has been 10 days since this pull request was last updated. |
|
@dogganon it has been 12 days since this pull request was last updated. |
|
@dogganon it has been 20 days since this pull request was last updated. |
|
@dogganon it has been 13 days since this pull request was last updated. |
|
@dogganon it has been 22 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
14 similar comments
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
|
@dogganon it has been 12 days since this pull request was last updated. |
|
@dogganon it has been 7 days since this pull request was last updated. |
1 similar comment
|
@dogganon it has been 7 days since this pull request was last updated. |
Pull request overview
@Myoldmopar
Changes in this PR include:
setup.pywithpyproject.tomlfor zero-config (almost) wheel building. Under the hood,scikit-build-coreis used as the build system for interacting with CMake. Also it's much faster since it tells CMake to use Ninja by default.energyplustoenergyplus.core. This convertsenergyplusto a namespace package, which allows sub-packages released under EnergyPlus's "umbrella" to be included in the namespace. Currentlyenergyplus.core(the Python binding) is the only sub-package available (in this repo); In the future, there should be aenergyplus.datasetsfor auxiliary example IDFs and EPWs. Once we have that clean separation of functionality each package can be installed separately so I imagine the installation would be much more lightweight compared to using installers.scripts/dev/versioning.pyfor PEP 440. Sincescikit-build-coreis configured to usesetuptools_scmfor versioning, which in turn uses Git tags, tags are required to follow PEP 440. This should be relatively easy if the project had used a consistent, common versioning scheme. EnergyPlus is obviously not the case (mostly due to unconventional suffixes like "FollowupBuild" and "IOFreeze"). So I included a scriptversioning.pyinscripts/dev/to (hopefully) make future version tagging easier to get right, i.e. PEP 440 compliant. (Slidenote: CMake should be configured to pull versions from Git as well. Having two separate version-keeping systems is error-prone.)Reviewer
This will not be exhaustively relevant to every PR.